Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality for PCL transmission to ROS and automatic registration using ROS subscribers. #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dgitz
Copy link

@dgitz dgitz commented Apr 21, 2014

No description provided.

@lesire
Copy link
Member

lesire commented Apr 22, 2014

Hi @dgitz
Unfortunately, I cannot accept your pull request as is...
You must:

  • clean a bit the files (removing unneeded comments)
  • remove temp files (*~) from commits
  • make clear the changes in PTAMWrapper
  • remove the drone_mode param : for your deployment, you should use topic remapping instead


void EstimationNode::ptamCb(const std_msgs::StringConstPtr str)
{
//printf("Received: %d\n",str->data.length());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as already mentioned by @lesire remove such comments.

souljaboy764 pushed a commit to souljaboy764/tum_ardrone that referenced this pull request Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants